Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing alt text and IDs on homepage #124

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Rakielle
Copy link
Collaborator

@Rakielle Rakielle commented Jun 25, 2024

What does this PR change?

This PR addresses accessibility improvements on the homepage by adding missing alt text for images and ensuring proper usage of IDs for accordion elements.

Changes Made

  1. Added descriptive alt text for images to improve accessibility for screen readers.
  2. Added IDs for accordion headers and updated aria-labelledby attributes to ensure proper linkage.

Fixes #92
Fixes #111

@deneb-alpha deneb-alpha requested a review from a team June 25, 2024 12:21
Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Fixed wave errors:

  • 6x "Missing alternative text"
  • 1x "Linked image missing alternative text"

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha merged commit d0abef2 into uyuni-project:master Jun 25, 2024
@Rakielle Rakielle deleted the feat/add-alt-text-and-id branch July 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion header '+' image missing alt attribute Add Alternative Texts
3 participants